I guess most touched on all ...
1) CSR expansion is all about the conventions, offering a better convention option, offering another firework view restaurant for those expense accounts, maybe another venue for their wedding business which seems to be doing okay. Yes it will be more generic and probably water down the great theme at the resort. But rooms will fill with vacation and convention guests.
2) Riviera is a DVC, am sure you can book rooms like you can now, looks like your basic deluxe high rise hotels, but if they have standard Disney amenities it will not compete with it's counterparts off property that offer more, just pull in the standard Disney folks along with DVC members. DVC is Disney's thing now. Sad they have practically destroyed CBR for this along with the gondola.
3) Star Wars hotel ............ well I'll believe it when I see it. It will take a small demographic to fill it up and be successful. I think there will be lots of boxes to check in the next few years for this to move forward, as stated.
I don't think Disney tries to compete with anyone. Bonnet Creek is not on Disney property and folks who stay there, timeshares and hotels, are probably not interested in staying in Disney properties. Four Seasons is not really on Disney property since Disney sold them the land AND they pretty much had control of what FS built anyway. They provide a level of service Disney does not, and likely doesn't want to have to cater in that way. Disney Springs is Disney property but those folks have to go through Disney to do what they do to those hotels. They are filling a void that Disney is no longer interested in offering. I don't think we'll see any more value or moderates at Disney ... they are letting other brands fill that void. Just like Disney sold the land to Marriott to build the Flamingo Crossing hotels (with oversight of course), it provided a close by option for that void, that is not convenient to anywhere but Disney.
If Disney were truly trying to compete, they'd drop their rates to match what they offer .... but as long as folks will pay inflated prices they will continue to be an island of rooms. Disney hotels maintain a very high occupancy. AND most Disney Park guests don't even stay on property, never will, but Disney needs them in the parks.